Add support of enum unknown values #712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: whenever server returns new unsupported by client enum value it's a breaking changes, as `ResponseReader` tries to map raw string value to appropriate generated enum constant by `.valueOf`. Proposal: to have a fallback value called `$UNKNOWN`, so that any unsupported by client enum value is mapped to it. This will allow to handle such case gracefully.
|
@sav007 thanks for getting this taken care of 😄 are there equivalent prs for the other platforms by any chance? |
This was referenced Oct 30, 2017
BenSchwab
approved these changes
Nov 1, 2017
|
@jeffreydecker we will sync tomorrow with iOS regarding this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: whenever server returns new unsupported by client enum value it's a breaking changes, as
ResponseReadertries to map raw string value to appropriate generated enum constant by.valueOf.Proposal: to have a fallback value called
$UNKNOWN, so that any unsupported by client enum value is mapped to it. This will allow to handle such case gracefully.Examples:
https://github.com/apollographql/apollo-android/pull/712/files#diff-9a0209432c8d9c39a92ea1e525dbee0d
https://github.com/apollographql/apollo-android/pull/712/files#diff-d88c16e23165a268eb39d908f34c5ab7