Zeit micro support #347
Zeit micro support #347
Conversation
|
I think we might need an example on the README and update the list of integrations. |
|
That's a good suggestion
…On Sun, Apr 2, 2017 at 9:55 AM Reyad Attiyat ***@***.***> wrote:
I think we might need an example on the README and update the list of
integrations.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#347 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA-x3K7-Z7HJm2J2ghQeGXT7De1XeHmLks5rr9MGgaJpZM4Mws50>
.
|
| let query; | ||
| if (req.method === 'POST') { | ||
| try { | ||
| query = await json(req); |
There was a problem hiding this comment.
json is a function supplied with micro that is an async parser. the reason it is async is because it will use the request as a stream and will return the complete json once the full request payload is received.
| try { | ||
| query = await json(req); | ||
| } catch (err) { | ||
| query = undefined; |
There was a problem hiding this comment.
and then? i mean, where do you expect the server to respond with an error?
There was a problem hiding this comment.
actually by setting query to undefined it causes the runHttpQuery function to trigger an error. This is fundamentally what happens with the express middleware when the body is empty or not parsable
| @@ -9,6 +9,7 @@ require('../packages/graphql-server-express/dist/connectApollo.test'); | |||
| require('../packages/graphql-server-hapi/dist/hapiApollo.test'); | |||
| if (NODE_MAJOR_VERSION >= 6) { | |||
| require('../packages/graphql-server-koa/dist/koaApollo.test'); | |||
| require('../packages/graphql-server-micro/dist/microApollo.test'); | |||
There was a problem hiding this comment.
no. it uses async await.
| }, | ||
| "devDependencies": { | ||
| "graphql-server-integration-testsuite": "^0.6.0", | ||
| "micro": "^7.3.0" |
There was a problem hiding this comment.
does micro package has embeded typings?
| "micro": "^7.3.0" | ||
| }, | ||
| "peerDependencies": { | ||
| "graphql": "^0.8.0 || ^0.9.0" |
| "graphql": "^0.8.0 || ^0.9.0" | ||
| }, | ||
| "optionalDependencies": { | ||
| "@types/graphql": "^0.9.0" |
There was a problem hiding this comment.
and @types/micro if such needed (see question above :))
.gitignore
Outdated
| @@ -27,7 +27,6 @@ build/Release | |||
|
|
|||
| # Dependency directory | |||
| node_modules | |||
| typings | |||
There was a problem hiding this comment.
isn't this old / left over from the old typings from the old version of typescript?
There was a problem hiding this comment.
Yep, but sometimes people still downloading typings locally, just wanted to make sure you didnt remove this to commit typings into the repo
| @@ -7,6 +7,7 @@ | |||
| * Restify: Fix for calling next() ([@jadkap](https://github.com/jadkap)) on [#285](https://github.com/apollostack/graphql-server/pull/285) | |||
| * Update GraphiQL to version 0.9.1 ([@ephemer](https://github.com/ephemer)) on [#293](https://github.com/apollostack/graphql-server/pull/293) | |||
| * Add AWS Lambda Integration [#101](https://github.com/apollostack/graphql-server/issues/101) | |||
| * Add Zeit Micro Integration [#324](https://github.com/apollographql/graphql-server/issues/324) | |||
There was a problem hiding this comment.
Have we really not released since adding AWS lamdba or did we (I?) just forget to update the changelog with the latest version?
| throw error; | ||
| } | ||
|
|
||
| if ( error.headers ) { |
There was a problem hiding this comment.
Is this something we added recently? I don't remember having this in the initial versions. What are people using those headers for?
| import {IncomingMessage, ServerResponse} from 'http'; | ||
|
|
||
| export interface MicroGraphQLOptionsFunction { | ||
| (req?: IncomingMessage): GraphQLOptions | Promise<GraphQLOptions>; |
There was a problem hiding this comment.
why the req parameter is considered optional?
This adds support for Zeit micro to allow GraphQL to be served as a function. Fixes issue #324
TODO: