[Do Not Merge] Update deprecate playground plugin #7584
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-server-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7eb9681:
|
Merged
glasser
reviewed
May 26, 2023
| @@ -1,6 +1,6 @@ | |||
| # GraphQL Playground plugin | |||
|
|
|||
| > ⚠️ Note: this package will be completely unsupported when Apollo Server v4 is officially released. This package exists for migration purposes only. We do not intend to resolve security issues or other bugs with this package if they arise, so please migrate away from this to Apollo Server's default Explorer as soon as possible. ⚠️ | |||
| > ⚠️ Note: this package is unsupported. This package exists for v4 migration purposes only. We do not intend to resolve security issues or other bugs with this package if they arise, so please migrate away from this to Apollo Server's default Explorer as soon as possible. ⚠️ | |||
There was a problem hiding this comment.
I wonder if we should (a) link to https://www.apollographql.com/docs/apollo-server/previous-versions and (b) add something specific about this package there?
There was a problem hiding this comment.
Updated for (a) but this package seems a bit specific to be called out in (b). If you have a specific recommendation for (b) I'll consider it?
glasser
approved these changes
May 26, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to trevor/update-deprecate-playground-plugin, this PR will be updated. # Releases ## @apollo/server-plugin-landing-page-graphql-playground@4.0.1 ### Patch Changes - [#7584](#7584) [`f4c3cd9b6`](f4c3cd9) Thanks [@trevor-scheer](https://github.com/trevor-scheer)! - Officially deprecate Playground plugin via README update Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
The intent of this PR is complete, the newly published patch with README update can be seen here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only exists as a simple mechanism to releasing a patch to our deprecated GraphQL Playground plugin. This should not land to
main, as we don't want to actually restore the source code for this plugin.