Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugins-event-reference.mdx #7739

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

simpyparveen
Copy link
Contributor

We do not have requestWillStart that throws unexpectedErrorProcessingRequest, but I have tested it that requestDidStart throws a unexpectedErrorProcessingRequest error.

We do not have `requestWillStart` that throws `unexpectedErrorProcessingRequest`, but I have tested it that `requestDidStart` throws a `unexpectedErrorProcessingRequest` error.
@apollo-cla
Copy link

@simpyparveen: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@netlify
Copy link

netlify bot commented Sep 27, 2023

👷 Deploy request for apollo-server-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 4005711

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4005711:

Sandbox Source
Apollo Server Typescript Configuration
Apollo Server Configuration

Copy link
Member

@trevor-scheer trevor-scheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Correct, requestWillStart is not a real hook 😄

@trevor-scheer trevor-scheer merged commit 64bb9b0 into apollographql:main Sep 27, 2023
2 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants