Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a single caching implementation #217

Closed
garypen opened this issue Nov 30, 2021 · 2 comments · Fixed by #235
Closed

Create a single caching implementation #217

garypen opened this issue Nov 30, 2021 · 2 comments · Fixed by #235
Assignees

Comments

@garypen
Copy link
Contributor

garypen commented Nov 30, 2021

Describe the solution you'd like

Recent caching changes have resulted in two copies of caching code in the router both doing the same thing. We'd like to have
one solution, with tests, which make it easy to use.

Describe alternatives you've considered

We have discussed adopting existing open source caching solutions that more fully represent our requirements. We aren't aware of one that matches our, admittedly fairly woolly, requirements. Improving the quality of our implementation will make it easier to work with and/or replace in the future.

Additional context
N/A

@cecton
Copy link
Contributor

cecton commented Dec 1, 2021

One way to find a crate that would do exactly what we need is to look at the dependents crate on crates.io: https://crates.io/crates/lru/reverse_dependencies

Of course it's always better if we can find something thoroughly tested and that fits perfectly. But I understand this might not be possible. Rust's ecosystem is still young, not everything is in there... if we do happen to create our own stuff I'd suggest to make a new crate specialized for that and license it under MIT OR Apache-2.0 for the community.

@garypen
Copy link
Contributor Author

garypen commented Dec 8, 2021

fixed: #235
(some outstanding issues are extracted into #244 )

@garypen garypen closed this as completed Dec 8, 2021
@abernix abernix added 2021-12 and removed triage labels Dec 13, 2021
@abernix abernix linked a pull request Dec 13, 2021 that will close this issue
tinnou pushed a commit to Netflix-Skunkworks/router that referenced this issue Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants