Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apollo Tracing (e.g., inline tracing support) #74

Closed
abernix opened this issue Jul 7, 2021 · 0 comments · Fixed by #1514
Closed

Apollo Tracing (e.g., inline tracing support) #74

abernix opened this issue Jul 7, 2021 · 0 comments · Fixed by #1514
Assignees

Comments

@abernix
Copy link
Member

abernix commented Jul 7, 2021

Adds FTV1 support.

A new open telemetry exporter has been added that will convert regular traces to Apollo traces.

A buffer of spans is collected on the server side which will retain spans until the root request span is completed.
Once a request is completed the trace will be reconstructed and sent to Apollo.

Span attributes that are only relevant to Apollo tracing are prefixed with apollo_private. and are filtered out of other APM data.

@glasser Has given some guidance on how we should improve tracing, but this'll be left to followup tickets as this PR is large and has been ongoing for a significant period.

#1728.
#1729.
As an aside, this PR demonstrates that spans can be used for Apollo tracing, and that we could move to a native Otel based solution in future.

@o0Ignition0o o0Ignition0o transferred this issue from another repository Nov 4, 2021
@Geal Geal mentioned this issue Nov 10, 2021
5 tasks
@abernix abernix mentioned this issue Aug 19, 2022
2 tasks
@abernix abernix added this to the v1.0.0-alpha.1 milestone Aug 30, 2022
@abernix abernix modified the milestones: v1.0.0-alpha.1, v1.0.0-alpha.2, v1.0.0-alpha.3, v1.0.0-alpha.4, post-v1.0 Sep 2, 2022
@BrynCooke BrynCooke linked a pull request Sep 8, 2022 that will close this issue
2 tasks
@abernix abernix modified the milestones: post-v1.0, v1.0.0-rc.0 Sep 15, 2022
tinnou pushed a commit to Netflix-Skunkworks/router that referenced this issue Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants