Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documentation for spaceport #445

Merged
merged 2 commits into from
Feb 11, 2022
Merged

add documentation for spaceport #445

merged 2 commits into from
Feb 11, 2022

Conversation

garypen
Copy link
Contributor

@garypen garypen commented Feb 11, 2022

Minimal documentation to support spaceport configuration.

Minimal documentation to support spaceport configuration.
Separate the graph and spaceport configuration into their own sections.

Re-order so graph comes before spaceport, which makes most sense.
@abernix abernix linked an issue Feb 11, 2022 that may be closed by this pull request
@garypen garypen merged commit 1a34cc3 into main Feb 11, 2022
@garypen garypen deleted the garypen/444-spaceport-docs branch February 11, 2022 13:34
The reference fulfills the same function as the APOLLO_GRAPH_REF environment variable.
NB: These environment variables are *not* currently recognised by the router. This is being tracked by [issue](https://github.com/apollographql/router/issues/425)

### Spaceport Configuration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Spaceport Configuration
### Spaceport configuration

listener: 0.0.0.0:50051
```

#### Internal Spaceport
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### Internal Spaceport
#### Internal spaceport

This is the default and is most appropriate for evaluations, demos, development support and generally getting started. This requires no configuration by default and will be automatically started if the graph configuration is present.
In this mode it is possible to further configure the address at which the internal spaceport is listening and the address of the spaceport to use. This should only be necessary if there is a clash on the default port, for instance if running multiple routers on the same system or clashing with another application.

#### External Spaceport
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### External Spaceport
#### External spaceport


Spaceport reports usage data to the Apollo ingress. You can see how it is configured in the examples above.

NB: This component is still evolving and you should expect functionality to change and evolve here. We are actively seeking user feedback as we work to shape this component.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
NB: This component is still evolving and you should expect functionality to change and evolve here. We are actively seeking user feedback as we work to shape this component.
> Note: This component is still evolving and you should expect functionality to change and evolve here. We are actively seeking user feedback as we work to shape this component.

key: service:<redacted>
```

You must configure the graph section. If you specify a graph section, then both the reference and the key must be specified. The reference must refer to a valid graph/version combination against which statistics are reported. The Key must be a valid API key which can be used for reporting statistics.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You must configure the graph section. If you specify a graph section, then both the reference and the key must be specified. The reference must refer to a valid graph/version combination against which statistics are reported. The Key must be a valid API key which can be used for reporting statistics.
You must configure the `graph` section. If you specify a `graph` section, then both the `reference` and the `key` must be specified. The `reference` must refer to a valid graph/variant combination (i.e., the "graph ref") against which statistics are reported. The `key` must be a valid Apollo Studio API key which can be used for reporting statistics (a [Studio Graph _Contributor_ token](https://www.apollographql.com/docs/studio/org/members/#organization-wide-member-roles) is appropriate).


You must configure the graph section. If you specify a graph section, then both the reference and the key must be specified. The reference must refer to a valid graph/version combination against which statistics are reported. The Key must be a valid API key which can be used for reporting statistics.
For more details on this process, refer to the [usage reporting documentation](https://www.apollographql.com/docs/studio/metrics/usage-reporting/)
The key fulfills the same function as the APOLLO_KEY environment variable.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The key fulfills the same function as the APOLLO_KEY environment variable.
The key fulfills the same function as the `APOLLO_KEY` environment variable.

You must configure the graph section. If you specify a graph section, then both the reference and the key must be specified. The reference must refer to a valid graph/version combination against which statistics are reported. The Key must be a valid API key which can be used for reporting statistics.
For more details on this process, refer to the [usage reporting documentation](https://www.apollographql.com/docs/studio/metrics/usage-reporting/)
The key fulfills the same function as the APOLLO_KEY environment variable.
The reference fulfills the same function as the APOLLO_GRAPH_REF environment variable.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The reference fulfills the same function as the APOLLO_GRAPH_REF environment variable.
The `reference` fulfills the same function as the `APOLLO_GRAPH_REF` environment variable.

For more details on this process, refer to the [usage reporting documentation](https://www.apollographql.com/docs/studio/metrics/usage-reporting/)
The key fulfills the same function as the APOLLO_KEY environment variable.
The reference fulfills the same function as the APOLLO_GRAPH_REF environment variable.
NB: These environment variables are *not* currently recognised by the router. This is being tracked by [issue](https://github.com/apollographql/router/issues/425)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
NB: These environment variables are *not* currently recognised by the router. This is being tracked by [issue](https://github.com/apollographql/router/issues/425)
> Note: These environment variables are *not* currently recognised by the router. This is being tracked by [#425](https://github.com/apollographql/router/issues/425)

@abernix
Copy link
Member

abernix commented Feb 11, 2022

Meh, well, my suggested changes can't be auto-clicked in now, but it was mostly formatting.

abernix added a commit that referenced this pull request Feb 17, 2022
Follows up: #445
Follows up: #309

Relates to: #66
Relates to: #444
abernix added a commit that referenced this pull request Feb 17, 2022
Follows up: #445
Follows up: #309

Relates to: #66
Relates to: #444
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add documentation for spaceport
4 participants