Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use graphiql option variables if query variables are not supplied #255

Merged
merged 1 commit into from
Jan 23, 2017
Merged

Use graphiql option variables if query variables are not supplied #255

merged 1 commit into from
Jan 23, 2017

Conversation

alanchristensen
Copy link
Contributor

@alanchristensen alanchristensen commented Dec 26, 2016

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

Closes #193

@apollo-cla
Copy link

@alanchristensen: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

Copy link
Contributor

@DxCx DxCx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, just one question, why did you remove the typings there?

import 'mocha';

import testSuite, { Schema } from 'graphql-server-integration-testsuite';

function createApp(createOptions: HapiPluginOptions) {
function createApp(createOptions) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why removing the typings...?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi DxCx,
createOptions can be either a HapiPluginOptions or GraphiQLPluginOptions now. My options were to either create a new type just for this test function that contained a graphqlOptions and graphiqlOptions or remove the type.

Is there another option that I'm missing? My typescript is pretty weak.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

createOptions: (HapiPluginOptions | GraphiQLPluginOptions) should work ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, that worked. I had to cast and check for the presence of .graphqlOptions and .graphiqlOptions further below.

Copy link
Contributor

@DxCx DxCx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@DxCx
Copy link
Contributor

DxCx commented Jan 19, 2017

@helfer lets merge this as well as soon as @alanchristensen is rebasing the code upon latest :)

@DxCx
Copy link
Contributor

DxCx commented Jan 19, 2017

0.5.1 branch is merged :)
@alanchristensen can you rebase? or i'll?

@alanchristensen
Copy link
Contributor Author

@DxCx I've rebased it.

@DxCx
Copy link
Contributor

DxCx commented Jan 23, 2017

thanks @alanchristensen :)
@helfer can we merge?

@helfer
Copy link
Contributor

helfer commented Jan 23, 2017

Thanks @alanchristensen ! 🙂

@helfer helfer merged commit 5d60519 into apollographql:master Jan 23, 2017
@helfer helfer removed the ready label Jan 23, 2017
trevor-scheer pushed a commit that referenced this pull request May 6, 2020
Remove `willUpdateManifest` method from #251 / #246, for now.
trevor-scheer pushed a commit that referenced this pull request May 12, 2020
Remove `willUpdateManifest` method from #251 / #246, for now.
trevor-scheer pushed a commit that referenced this pull request May 14, 2020
Remove `willUpdateManifest` method from #251 / #246, for now.
trevor-scheer pushed a commit that referenced this pull request May 14, 2020
Remove `willUpdateManifest` method from #251 / #246, for now.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants