Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRO-1612 Initial #1

Merged
merged 6 commits into from
Jun 25, 2021
Merged

PRO-1612 Initial #1

merged 6 commits into from
Jun 25, 2021

Conversation

stuartromanek
Copy link
Member

No description provided.

@stuartromanek stuartromanek marked this pull request as ready for review June 21, 2021 16:53
@stuartromanek stuartromanek changed the title Initial PRO-1612 Initial Jun 21, 2021
@linear
Copy link

linear bot commented Jun 21, 2021

Copy link
Contributor

@abea abea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of eslint errors to resolve. I added it to our Circle account, which automatically added the commit you'll need to pull.

README.md Outdated
Apostrophe 2 supported creating relationships to multiple doc types from a single interface. This feature is still being ported to Apostrophe 3, as such redirects can only specify a single doc type to redirect to.
## Installation

First make sure you have an [Apostrophe project](http://apostrophecms.org/)!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.com

index.js Outdated
statusCode: 302,
openGraph: false, // Disables @apostrophecms/open-graph for redirects
seo: false, // Disables @apostrophecms/seo for redirects
sitemap: false // Disables @apostrophecms/sitemap for redirects
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't do anything here. It doesn't have a piece page, so there's no URL to display. I'm also pretty sure the option doesn't actually exist in A2 sitemap module.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, in A2 it simply suppressed the goofy priority field.

@stuartromanek stuartromanek requested a review from abea June 25, 2021 12:59
@stuartromanek stuartromanek merged commit 4887175 into main Jun 25, 2021
@stuartromanek stuartromanek deleted the initial branch June 25, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants