Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRO-2372: extensibility #10

Merged
merged 1 commit into from
Dec 17, 2021
Merged

PRO-2372: extensibility #10

merged 1 commit into from
Dec 17, 2021

Conversation

boutell
Copy link
Member

@boutell boutell commented Dec 16, 2021

No description provided.

@boutell boutell requested a review from abea December 16, 2021 15:11
@linear
Copy link

linear bot commented Dec 16, 2021

PRO-2372 As a Michelin developer, I can have more hooks to override the checkRedirect method of the redirects module

We discussed this with Stephane as part of their needs to migrate the @dgad/redirects module to A3. Rather than copying/pasting so much of the Apostrophe code into their own module, they would benefit from some specific hooks to allow them to add their custom redirect logic in here.

Tom suggested something like this could work, see lines 148-150, 175, and 180.

image.png

@boutell
Copy link
Member Author

boutell commented Dec 16, 2021

See linear ticket for dev QA details.

@boutell boutell merged commit 1364932 into main Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abea abea abea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boutell @abea