Skip to content

Conversation

BaiyangZhou
Copy link
Contributor

@BaiyangZhou BaiyangZhou commented Apr 22, 2025

This PR aims to fix the error from CI
go: golang.org/x/sys@v0.31.0 requires go >= 1.23.0 (running go 1.22.9; GOTOOLCHAIN=local) make: *** [Makefile:30: go-mod-update] Error 1 {"component":"entrypoint","error":"wrapped process failed: exit status
So we need to update the Golang version inside .ci-operator.yaml to 1.23

Reference link: https://redhat-internal.slack.com/archives/G019KPS1S6R/p1745256764181379

@openshift-ci openshift-ci bot requested review from opokornyy and tremes April 22, 2025 04:53
Update the Golang version of .ci-operator.yaml
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.16%. Comparing base (f6b5bd6) to head (b8946bd).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #483   +/-   ##
=======================================
  Coverage   46.16%   46.16%           
=======================================
  Files          22       22           
  Lines        1083     1083           
=======================================
  Hits          500      500           
  Misses        553      553           
  Partials       30       30           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@ncaak ncaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Apr 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BaiyangZhou, ncaak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7e85870 into app-sre:master Apr 22, 2025
8 checks passed
@BaiyangZhou BaiyangZhou deleted the update-ci-image branch June 18, 2025 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants