Skip to content

Conversation

ncaak
Copy link
Contributor

@ncaak ncaak commented Apr 25, 2025

summary

Add ImageDigestMirrorSet manifest to link Konflux images with future registry images' links

misc

  • Some refactoring on the manifests for Snapshot and Release
  • Added missing FBC task for FIPS on Konflux pipeline

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 25, 2025

@ncaak: This pull request references DVO-213 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

summary

Add ImageDigestMirrorSet manifest to link Konflux images with future registry images' links

misc

  • Some refactoring on the manifests for Snapshot and Release
  • Added missing FBC task for FIPS on Konflux pipeline

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Apr 25, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Apr 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ncaak ncaak force-pushed the konflux/mirror-images-setup branch from 1bdd120 to 2b5cba8 Compare April 25, 2025 15:42
@ncaak
Copy link
Contributor Author

ncaak commented Apr 25, 2025

Images from Konflux CI tested successfully. Ready for review.

@ncaak ncaak marked this pull request as ready for review April 25, 2025 16:01
@openshift-ci openshift-ci bot requested review from BaiyangZhou and tremes April 25, 2025 16:01
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.16%. Comparing base (ea6bc93) to head (2b5cba8).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #486   +/-   ##
=======================================
  Coverage   46.16%   46.16%           
=======================================
  Files          22       22           
  Lines        1083     1083           
=======================================
  Hits          500      500           
  Misses        553      553           
  Partials       30       30           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@opokornyy
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 28, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 94ee9ab into app-sre:master Apr 28, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants