-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aws-garbage-collector] introduce new integration #84
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The integration is great, and I don't see any major issues with the structure and workflow. I've given below some feedback, which summarizes in:
- you seem to be capturing a lot of generic exceptions, I wish we could make it more robust instead. If you can try to improve things like this it would be great:
except KeyError as e:
if 'Tags' in e.message:
- there are some functions that can be refactored
- minor style things like using list comprehensions more often etc
- be more strict ith the exact naming patterns this integration will skip. doing
if 'stag' in name
seems a bit too generic, maybe? it's a hard problem to solve, though...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!!! 🚀
this integration does:
stage
orprod
managed_by_integration
- ignores resources managed byterraform-resources
andterraform-users
owner
- ignores some resources managed by terraform (HK)aws_gc_hands_off
- ignores manually managed resourcesthis integration does not:
safety nets:
enable-deletion
should be set to truesupported aws resources: