Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: undefined value reference #1208

Merged
merged 1 commit into from
Nov 17, 2023
Merged

fix: undefined value reference #1208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/renderer/actions/Session.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,8 @@ export function newSession (caps, attachSessId = null) {
const {protocol, hostname, port, path} = serverOpts;
try {
const detailsUrl = `${protocol}://${hostname}:${port}${path.replace(/\/$/, '')}/session/${attachSessId}`;
attachedSessionCaps = (await axios(detailsUrl).data).value;
const res = await axios({url: detailsUrl, headers: { 'content-type': HEADERS_CONTENT }, timeout: CONN_TIMEOUT});
attachedSessionCaps = res.data.value;
} catch (err) {
// rethrow the error as session not running, but first log the original error to
// console
Expand Down
Loading