-
-
Notifications
You must be signed in to change notification settings - Fork 14
merging beta branch, and doing appium beta cleanup tasks #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
will version and publish after this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you've imported parse
this local variable will clash now.
er. ci failed. fixing... |
looks like it complained because of mochawait. but good news because mochawait is no longer required! |
lib/xcode.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does import { x as y} from z;
not work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooh that's what I was looking for. Thanks.
@jlipps yeah I removed mochawait as a dep, but I guess it needs to be removed from appium-gulp-plugins as well. |
mochawait is still being imported in xcode-specs. |
ah, that's it isaac thanks. Hoo boy, glad you said that, because this is what the error looks like on my machine:
|
but removing that import line fixes it. The error doesn't seem easy to figure out at all. |
Ah! Babelized stack traces. |
the CI error explicitly mentioned mochawait.... |
that's what we get for using the cool stuff ;) |
merging beta branch, and doing appium beta cleanup tasks
No description provided.