Skip to content

Conversation

Jonahss
Copy link
Member

@Jonahss Jonahss commented Sep 15, 2015

No description provided.

@Jonahss
Copy link
Member Author

Jonahss commented Sep 15, 2015

will version and publish after this PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you've imported parse this local variable will clash now.

@Jonahss
Copy link
Member Author

Jonahss commented Sep 15, 2015

er. ci failed. fixing...

@jlipps
Copy link
Member

jlipps commented Sep 15, 2015

looks like it complained because of mochawait. but good news because mochawait is no longer required!

lib/xcode.js Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does import { x as y} from z; not work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh that's what I was looking for. Thanks.

@Jonahss
Copy link
Member Author

Jonahss commented Sep 15, 2015

@jlipps yeah I removed mochawait as a dep, but I guess it needs to be removed from appium-gulp-plugins as well.

@imurchie
Copy link
Contributor

mochawait is still being imported in xcode-specs.

@Jonahss
Copy link
Member Author

Jonahss commented Sep 15, 2015

ah, that's it isaac thanks. Hoo boy, glad you said that, because this is what the error looks like on my machine:

[14:31:53] Error in plugin 'gulp-mocha'
Message:
    Cannot find module 'babel-runtime/helpers/sliced-to-array'
Details:
    code: MODULE_NOT_FOUND
Stack:
Error: Cannot find module 'babel-runtime/helpers/sliced-to-array'
    at Function.Module._resolveFilename (module.js:336:15)
    at Function.Module._load (module.js:286:25)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/Users/jonahss/Workspace/node_modules/mochawait/build/lib/mochawait.js:3:22)
    at Module._compile (module.js:434:26)
    at Object.Module._extensions..js (module.js:452:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/Users/jonahss/Workspace/node_modules/mochawait/build/index.js:3:1)
    at Module._compile (module.js:434:26)
    at Object.Module._extensions..js (module.js:452:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (test/xcode-specs.js:5:46)
    at Module._compile (module.js:434:26)
    at Object.Module._extensions..js (module.js:452:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at /Users/jonahss/Workspace/appium-xcode/node_modules/appium-gulp-plugins/node_modules/mocha/lib/mocha.js:216:27
    at Array.forEach (native)
    at Mocha.loadFiles (/Users/jonahss/Workspace/appium-xcode/node_modules/appium-gulp-plugins/node_modules/mocha/lib/mocha.js:213:14)

@Jonahss
Copy link
Member Author

Jonahss commented Sep 15, 2015

but removing that import line fixes it. The error doesn't seem easy to figure out at all.

@imurchie
Copy link
Contributor

Ah! Babelized stack traces.

@jlipps
Copy link
Member

jlipps commented Sep 15, 2015

the CI error explicitly mentioned mochawait....

@Jonahss
Copy link
Member Author

Jonahss commented Sep 15, 2015

that's what we get for using the cool stuff ;)

Jonahss added a commit that referenced this pull request Sep 15, 2015
merging beta branch, and doing appium beta cleanup tasks
@Jonahss Jonahss merged commit 54f562f into appium:master Sep 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants