Fix Android tests and add them to CI #1002
Conversation
.travis.yml
Outdated
| - nvm install 8 | ||
| - node --version | ||
| - npm --version | ||
| - npm install -g appium |
There was a problem hiding this comment.
Have added few env variables in travis, so you can use it. npm install -g $appiumVersion
There was a problem hiding this comment.
Ok Will update this. Does it need the below PR to be merged?
There was a problem hiding this comment.
Nope. You can use right away.
| filter { | ||
| includeTestsMatching '*.SettingTest' | ||
| includeTestsMatching 'io.appium.java_client.android.ClipboardTest' | ||
| includeTestsMatching '*.AndroidAppStringsTest' |
There was a problem hiding this comment.
Any reason why we have only three test classes? We can include all tests under android package.
There was a problem hiding this comment.
Few tests run only on real devices, few needs adb to run as root and few are flaky (depends on the android emulator). Hence, included only those which are consistently running. Other tests can be picked once travis supports latest Emulator.
| public class UIAutomator2Test { | ||
| private static AppiumDriverLocalService service; | ||
| protected static AndroidDriver<AndroidElement> driver; | ||
| public class UIAutomator2Test extends BaseAndroidTest { |
There was a problem hiding this comment.
this class can be deleted and all the tests can be moved to AndroidDriverTest.
There was a problem hiding this comment.
AndroidDriverTest is not running in CI currently. Can this be done later?
There was a problem hiding this comment.
@SrinivasanTarget ping
|
@SrinivasanTarget CI is failing as iOS tests not running due to missing env variables. |
.travis.yml
Outdated
| @@ -1,3 +1,4 @@ | |||
| language: java | |||
There was a problem hiding this comment.
remove this its not required.
|
@shridharkalagi It's not failing due to env variables. I will have a look. |
|
@SrinivasanTarget can you check this pls? |
|
@shridharkalagi fix conflicts pls |
shridharkalagi
force-pushed
the
fixAndroidCI
branch
from
30116f9 to
f6d4da3
Compare
|
Fixed the conflicts. @SrinivasanTarget iOS CI is failing. Can you have a look? |
|
@shridharkalagi Travis is fine now. Make Codacy happy. |
Change list
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that applyDetails
Have Included few tests in CI which always pass on the latest version on Android Emulator available on travis (android-25)