Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the missing Android and iOS settings #1120

Merged
merged 3 commits into from
Mar 12, 2019
Merged

Add the missing Android and iOS settings #1120

merged 3 commits into from
Mar 12, 2019

Conversation

mykola-mokhnach
Copy link
Contributor

Change list

Addresses #1119

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@saikrishna321
Copy link
Member

@mykola-mokhnach can you pls get travis happy

/home/travis/build/appium/java-client/src/main/java/io/appium/java_client/android/HasAndroidSettings.java:119: error: bad HTML entity
     * Whether to return compact (standards-compliant) & faster responses in find element/s

@saikrishna321 saikrishna321 merged commit 9d33a4e into appium:master Mar 12, 2019
@mykola-mokhnach mykola-mokhnach deleted the settings branch April 17, 2019 14:16
@ogasawara-shift ogasawara-shift mentioned this pull request Jul 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikrishna321 saikrishna321 saikrishna321 approved these changes

@SrinivasanTarget SrinivasanTarget SrinivasanTarget approved these changes

@jlipps jlipps Awaiting requested review from jlipps

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mykola-mokhnach @saikrishna321 @SrinivasanTarget