Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the missing settings which introduced in appium 1.12 and 1.13 #1156

Merged
merged 1 commit into from
Jun 14, 2019
Merged

Add the missing settings which introduced in appium 1.12 and 1.13 #1156

merged 1 commit into from
Jun 14, 2019

Conversation

takeyaqa
Copy link
Contributor

Change list

  • add the missing settings which introduced in appium 1.12 and 1.13
    • shutdownOnPowerDisconnect
    • mjpegScalingFactor
    • autoUpdateImageElementPosition
    • fixImageTemplateScale
    • defaultImageTemplateScale
  • fix javadocs
    • use https
    • fix wrong default values
  • add tests

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@takeyaqa
add the missing setting which introduced in appium 1.12 and 1.13
45a365a 
* add the missing setting which introduced in appium 1.12 and 1.13
* fix javadoc
* add test
@mykola-mokhnach
Copy link
Contributor

thanks

@mykola-mokhnach mykola-mokhnach merged commit 1aac740 into appium:master Jun 14, 2019
@takeyaqa takeyaqa deleted the add_missing_settings branch June 14, 2019 17:03
@ogasawara-shift ogasawara-shift mentioned this pull request Jul 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mykola-mokhnach mykola-mokhnach mykola-mokhnach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@takeyaqa @mykola-mokhnach