-
-
Notifications
You must be signed in to change notification settings - Fork 768
fix: chinese garbled characters #1617 #1618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/main/java/io/appium/java_client/service/local/AppiumDriverLocalService.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/service/local/AppiumDriverLocalService.java
Show resolved
Hide resolved
@@ -410,16 +411,15 @@ static Slf4jLogMessageContext parseSlf4jContextFromLogMessage(String logMessage) | |||
public void addLogMessageConsumer(Consumer<String> consumer) { | |||
checkNotNull(consumer, "consumer parameter is NULL!"); | |||
addOutPutStream(new OutputStream() { | |||
StringBuilder lineBuilder = new StringBuilder(); | |||
private ByteArrayOutputStream outputStream = new ByteArrayOutputStream(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should the property be final
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes , final
is better
Could you please sign the CLA? |
will CLA affect my pr? |
I cannot merge it without CLA being signed |
👌i will do this later |
@mykola-mokhnach I am facing issue with latest java-client to launch appium service. Does anything changed around this? While trying to programmatically open appium server using java-client 8.0.0 I see below error msg: io.appium.java_client.service.local.AppiumServerHasNotBeenStartedLocallyException: The local appium server has not been started. The given Node.js executable: /usr/local/bin/appium Arguments: [/usr/local/lib/node_modules/appium/lib/appium.js, --port, 18384, --address, 0.0.0.0] Sample Start-up code(worked on java-client 8.0.0-beta version: service = AppiumDriverLocalService Appium Version Used: 1.20.0 and 1.22.0 |
fix #1617
Change list
avoid chinese garbled characters
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
x
in the boxes that applyDetails
details #1617