Skip to content

fix: Update the environment argument type #1712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 21, 2022
Merged

fix: Update the environment argument type #1712

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d1d170
fix: Update the environment argument type
mykola-mokhnach Jun 19, 2022
b8ea75f
Update var name
mykola-mokhnach Jun 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/main/java/io/appium/java_client/mac/options/SupportsEnvironmentOption.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import io.appium.java_client.remote.options.CanSetCapability;
import org.openqa.selenium.Capabilities;

import java.util.List;
import java.util.Map;
import java.util.Optional;

public interface SupportsEnvironmentOption<T extends BaseOptions<T>> extends
Expand All @@ -33,20 +33,20 @@ public interface SupportsEnvironmentOption<T extends BaseOptions<T>> extends
* the parent process. This capability is only going to be applied if the application
* is not running on session startup.
*
* @param arguments E.g. ["--help"].
* @param env E.g. ["--help"].
* @return self instance for chaining.
*/
default T setEnvironment(List<String> arguments) {
return amend(ENVIRONMENT_OPTION, arguments);
default T setEnvironment(Map<String, String> env) {
return amend(ENVIRONMENT_OPTION, env);
}

/**
* Get the application environment variables mapping.
*
* @return Application environment mapping.
*/
default Optional<List<String>> getEnvironment() {
default Optional<Map<String, String>> getEnvironment() {
//noinspection unchecked
return Optional.ofNullable((List<String>) getCapability(ENVIRONMENT_OPTION));
return Optional.ofNullable((Map<String, String>) getCapability(ENVIRONMENT_OPTION));
}
}