Skip to content

refactor: Deprecate Appium ByAll #1740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2022
Merged

refactor: Deprecate Appium ByAll #1740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/io/appium/java_client/pagefactory/DefaultElementByBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
import io.appium.java_client.pagefactory.bys.ContentMappedBy;
import io.appium.java_client.pagefactory.bys.ContentType;
import io.appium.java_client.pagefactory.bys.builder.AppiumByBuilder;
import io.appium.java_client.pagefactory.bys.builder.ByAll;
import io.appium.java_client.pagefactory.bys.builder.ByChained;
import io.appium.java_client.pagefactory.bys.builder.HowToUseSelectors;
import org.openqa.selenium.By;
Expand All @@ -32,6 +31,7 @@
import org.openqa.selenium.support.FindAll;
import org.openqa.selenium.support.FindBy;
import org.openqa.selenium.support.FindBys;
import org.openqa.selenium.support.pagefactory.ByAll;

import java.lang.annotation.Annotation;
import java.lang.reflect.AnnotatedElement;
Expand Down
1 change: 1 addition & 0 deletions src/main/java/io/appium/java_client/pagefactory/bys/builder/AppiumByBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@

import org.openqa.selenium.By;
import org.openqa.selenium.support.pagefactory.AbstractAnnotations;
import org.openqa.selenium.support.pagefactory.ByAll;

import javax.annotation.Nullable;
import java.lang.annotation.Annotation;
Expand Down
15 changes: 14 additions & 1 deletion src/main/java/io/appium/java_client/pagefactory/bys/builder/ByAll.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,20 @@
import java.util.Optional;
import java.util.function.Function;


/**
* Mechanism used to locate elements within a document using a series of lookups. This class will
* find all DOM elements that matches any of the locators in sequence, e.g.
*
* <pre>
* driver.findElements(new ByAll(by1, by2))
* </pre>
*
* will find all elements that match <var>by1</var> and then all elements that match <var>by2</var>.
* This means that the list of elements returned may not be in document order.
*
* @deprecated Use {@link org.openqa.selenium.support.pagefactory.ByAll}
*/
@Deprecated
public class ByAll extends org.openqa.selenium.support.pagefactory.ByAll {

private final List<By> bys;
Expand Down