feat: use own User Agent #1779
Merged
feat: use own User Agent #1779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykola-mokhnach
approved these changes
Oct 24, 2022
valfirst
requested changes
Oct 24, 2022
src/test/java/io/appium/java_client/internal/AppiumUserAgentFilterTest.java
Outdated
Show resolved
Hide resolved
SrinivasanTarget
approved these changes
Oct 27, 2022
| ossrhPassword=your-jira-password | ||
|
|
||
| selenium.version=4.5.0 | ||
| # Please increment the value in a release |
There was a problem hiding this comment.
@mykola-mokhnach I do this manually. maybe its good to come up with a script or leaving it to dependabot can also be a good thing to do when there is a release.
src/main/java/io/appium/java_client/remote/AppiumCommandExecutor.java
Outdated
Show resolved
Hide resolved
valfirst
reviewed
Oct 28, 2022
valfirst
reviewed
Oct 28, 2022
valfirst
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll update this branch after #1747 merge.
This PR is based on #1747
Change list
By #1747, we can insert its own UA as the header. This PR tries to add it.
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that applyDetails
Please provide more details about changes if it is necessary. If there are new features you can provide code samples which show the way they
work and possible use cases. Also you can create gists with pasted java code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub