Skip to content

chore: use Lombok #1789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2022
Merged

chore: use Lombok #1789

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fde5a4
chore: use Lambok
KazuCocoa Nov 1, 2022
000fb8c
Update src/main/java/io/appium/java_client/remote/DirectConnect.java
KazuCocoa Nov 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/main/java/io/appium/java_client/remote/DirectConnect.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
package io.appium.java_client.remote;

import lombok.AccessLevel;
import lombok.Getter;
import lombok.experimental.Accessors;

import javax.annotation.Nullable;
import java.net.MalformedURLException;
import java.net.URL;
Expand All @@ -9,20 +13,20 @@

import static io.appium.java_client.internal.CapabilityHelpers.APPIUM_PREFIX;

// TODO: simplify with lombok as another PR
@Accessors
public class DirectConnect {
private static final String DIRECT_CONNECT_PROTOCOL = "directConnectProtocol";
private static final String DIRECT_CONNECT_PATH = "directConnectPath";
private static final String DIRECT_CONNECT_HOST = "directConnectHost";
private static final String DIRECT_CONNECT_PORT = "directConnectPort";

private final String protocol;
@Getter(AccessLevel.PUBLIC) private final String protocol;

private final String path;
@Getter(AccessLevel.PUBLIC) private final String path;

private final String host;
@Getter(AccessLevel.PUBLIC) private final String host;

private final String port;
@Getter(AccessLevel.PUBLIC) private final String port;

/**
* Create a DirectConnect instance.
Expand All @@ -35,10 +39,6 @@ public DirectConnect(Map<String, ?> responseValue) {
this.port = this.getDirectConnectValue(responseValue, DIRECT_CONNECT_PORT);
}

public String getProtocol() {
return protocol;
}

@Nullable
private String getDirectConnectValue(Map<String, ?> responseValue, String key) {
Object directConnectPath = responseValue.get(APPIUM_PREFIX + key);
Expand Down