Skip to content

perf: Improve performance of proxy Interceptor logging #1849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2023
Merged

perf: Improve performance of proxy Interceptor logging #1849

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/main/java/io/appium/java_client/proxy/Interceptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,10 @@ public static Object intercept(
} catch (NotImplementedException e) {
// ignore
} catch (Exception e) {
logger.error(
String.format("Got an unexpected error in beforeCall listener of %s.%s method",
self.getClass().getName(), method.getName()), e
);
logger.atError()
.addArgument(() -> self.getClass().getName())
.addArgument(method::getName)
.log("Got an unexpected error in beforeCall listener of {}.{} method", e);
}
});

Expand Down Expand Up @@ -118,10 +118,10 @@ public static Object intercept(
} catch (NotImplementedException e) {
// ignore
} catch (Exception e) {
logger.error(
String.format("Got an unexpected error in afterCall listener of %s.%s method",
self.getClass().getName(), method.getName()), e
);
logger.atError()
.addArgument(() -> self.getClass().getName())
.addArgument(method::getName)
.log("Got an unexpected error in afterCall listener of {}.{} method", e);
}
});
return endResult;
Expand Down