Skip to content

feat: Add SupportsEnforceAppInstallOption to XCUITestOptions #1895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2023
Merged

feat: Add SupportsEnforceAppInstallOption to XCUITestOptions #1895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/io/appium/java_client/android/options/EspressoOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
import io.appium.java_client.android.options.app.SupportsAppWaitDurationOption;
import io.appium.java_client.android.options.app.SupportsAppWaitPackageOption;
import io.appium.java_client.android.options.app.SupportsAutoGrantPermissionsOption;
import io.appium.java_client.android.options.app.SupportsEnforceAppInstallOption;
import io.appium.java_client.android.options.app.SupportsIntentOptionsOption;
import io.appium.java_client.android.options.app.SupportsRemoteAppsCacheLimitOption;
import io.appium.java_client.android.options.app.SupportsUninstallOtherPackagesOption;
Expand Down Expand Up @@ -89,6 +88,7 @@
import io.appium.java_client.remote.options.SupportsAppOption;
import io.appium.java_client.remote.options.SupportsAutoWebViewOption;
import io.appium.java_client.remote.options.SupportsDeviceNameOption;
import io.appium.java_client.remote.options.SupportsEnforceAppInstallOption;
import io.appium.java_client.remote.options.SupportsIsHeadlessOption;
import io.appium.java_client.remote.options.SupportsLanguageOption;
import io.appium.java_client.remote.options.SupportsLocaleOption;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/io/appium/java_client/android/options/UiAutomator2Options.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
import io.appium.java_client.android.options.app.SupportsAppWaitForLaunchOption;
import io.appium.java_client.android.options.app.SupportsAppWaitPackageOption;
import io.appium.java_client.android.options.app.SupportsAutoGrantPermissionsOption;
import io.appium.java_client.android.options.app.SupportsEnforceAppInstallOption;
import io.appium.java_client.android.options.app.SupportsIntentActionOption;
import io.appium.java_client.android.options.app.SupportsIntentCategoryOption;
import io.appium.java_client.android.options.app.SupportsIntentFlagsOption;
Expand Down Expand Up @@ -95,6 +94,7 @@
import io.appium.java_client.remote.options.SupportsClearSystemFilesOption;
import io.appium.java_client.remote.options.SupportsDeviceNameOption;
import io.appium.java_client.remote.options.SupportsEnablePerformanceLoggingOption;
import io.appium.java_client.remote.options.SupportsEnforceAppInstallOption;
import io.appium.java_client.remote.options.SupportsIsHeadlessOption;
import io.appium.java_client.remote.options.SupportsLanguageOption;
import io.appium.java_client.remote.options.SupportsLocaleOption;
Expand Down
2 changes: 2 additions & 0 deletions src/main/java/io/appium/java_client/ios/options/XCUITestOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@
import io.appium.java_client.remote.options.SupportsClearSystemFilesOption;
import io.appium.java_client.remote.options.SupportsDeviceNameOption;
import io.appium.java_client.remote.options.SupportsEnablePerformanceLoggingOption;
import io.appium.java_client.remote.options.SupportsEnforceAppInstallOption;
import io.appium.java_client.remote.options.SupportsIsHeadlessOption;
import io.appium.java_client.remote.options.SupportsLanguageOption;
import io.appium.java_client.remote.options.SupportsLocaleOption;
Expand Down Expand Up @@ -136,6 +137,7 @@ public class XCUITestOptions extends BaseOptions<XCUITestOptions> implements
SupportsOtherAppsOption<XCUITestOptions>,
SupportsAppPushTimeoutOption<XCUITestOptions>,
SupportsAppInstallStrategyOption<XCUITestOptions>,
SupportsEnforceAppInstallOption<XCUITestOptions>,
// WebDriverAgent options: https://github.com/appium/appium-xcuitest-driver#webdriveragent
SupportsXcodeCertificateOptions<XCUITestOptions>,
SupportsKeychainOptions<XCUITestOptions>,
Expand Down
9 changes: 9 additions & 0 deletions src/main/java/io/appium/java_client/remote/IOSMobileCapabilityType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,15 @@ public interface IOSMobileCapabilityType extends CapabilityType {
*/
String UPDATE_WDA_BUNDLEID = "updatedWDABundleId";

/**
* By default application installation is not skipped if newer or the same version of this app is already present on
* the device under test. Setting this option to {@code false} will enforce Appium to always skip the current
* application build. Defaults to {@code true}.
*
* @since 4.19.0
*/
String ENFORCE_APP_INSTALL = "enforceAppInstall";

/**
* Whether to perform reset on test session finish (false) or not (true).
* Keeping this variable set to true and Simulator running
Expand Down
6 changes: 2 additions & 4 deletions .../app/SupportsEnforceAppInstallOption.java → ...ions/SupportsEnforceAppInstallOption.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,8 @@
* limitations under the License.
*/

package io.appium.java_client.android.options.app;
package io.appium.java_client.remote.options;

import io.appium.java_client.remote.options.BaseOptions;
import io.appium.java_client.remote.options.CanSetCapability;
import org.openqa.selenium.Capabilities;

import java.util.Optional;
Expand All @@ -40,7 +38,7 @@ default T enforceAppInstall() {

/**
* Allows setting whether the application under test is always reinstalled even
* if a newer version of it already exists on the device under test. false by default.
* if a newer version of it already exists on the device under test. False (Android), true (iOS) by default.
*
* @param value True to allow test packages installation.
* @return self instance for chaining.
Expand Down