Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Update selenium dependencies to v4.14 #2036

Merged
merged 13 commits into from Oct 12, 2023

Conversation

mykola-mokhnach
Copy link
Contributor

@mykola-mokhnach mykola-mokhnach commented Oct 10, 2023

BREAKING CHANGE: The library is now only compatible to Java11 and above
BREAKING CHANGE: The previously deprecated MobileBy class has been removed. Use AppiumBy instead
BREAKING CHANGE: The previously deprecated launchApp, resetApp and closeApp methods have been removed. Use extension methods instead
BREAKING CHANGE: The previously deprecated WindowsBy class and related location strategies have been removed
BREAKING CHANGE: The previously deprecated ByAll class has been removed in favour of the Selenium one
BREAKING CHANGE: The previously deprecated AndroidMobileCapabilityType interface has been removed. Use driver options instead
BREAKING CHANGE: The previously deprecated IOSMobileCapabilityType interface has been removed. Use driver options instead
BREAKING CHANGE: The previously deprecated MobileCapabilityType interface has been removed. Use driver options instead
BREAKING CHANGE: The previously deprecated MobileOptions class has been removed. Use driver options instead
BREAKING CHANGE: The previously deprecated YouiEngineCapabilityType interface has been removed. Use driver options instead
BREAKING CHANGE: Removed several misspelled methods. Use properly spelled alternatives instead
BREAKING CHANGE: Removed startActivity method from AndroidDriver. Use 'mobile: startActivity' extension method instead
BREAKING CHANGE: Removed the previously deprecated APPIUM constant from the AutomationName interface
BREAKING CHANGE: Removed the previously deprecated PRE_LAUNCH value from the GeneralServerFlag enum
BREAKING CHANGE: Moved AppiumUserAgentFilter class to io.appium.java_client.internal.filters package

Removed dependencies to Apache Commons libraries

@mykola-mokhnach
Copy link
Contributor Author

cc @titusfortner

@mykola-mokhnach
Copy link
Contributor Author

Let me check failing tests before merging

@mykola-mokhnach
Copy link
Contributor Author

mykola-mokhnach commented Oct 10, 2023

Looks like most of the test errors are happening because of connection reset. I did not observe these in previous client version, so I'd assume it might something to do with the HTTP client change in Selenium lib.
SO says we could enforce HTTP version to 1.1 (which also makes sense because the server anyway does not support HTTP2), but there is no way to do tune that in selenium client for now. I'll ask selenium maintainers to add this feature, just not sure if we need to wait until it is released (which might take a while) or continue with what we have now?

cc @valfirst @saikrishna321 @asolntsev

@saikrishna321
Copy link
Member

Let's enforce to 1.1 and go forward.

@asolntsev
Copy link
Contributor

@mykola-mokhnach Yes, it seems you should force http 1.1

I've tried to run Selenide tests against your branch, and most of tests worked correctly, but few tests failed with errors like this:

Response code 500. Message: An unknown server-side error occurred while processing the command. Original error: Could not proxy command to the remote server. Original error: socket hang up

@mykola-mokhnach mykola-mokhnach merged commit 39c2526 into appium:master Oct 12, 2023
4 of 5 checks passed
@mykola-mokhnach mykola-mokhnach deleted the sel_4.14 branch October 12, 2023 18:34
@shreyansh791
Copy link

The previously deprecated MobileCapabilityType interface has been removed. Use driver options instead

Could you please explain what is the meaning of driver options here?

@valfirst
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants