refactor: Migrate to new Selenium API for process management #2054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valfirst
requested review from
mykola-mokhnach,
SrinivasanTarget and
saikrishna321
as code owners
| process.setEnvironmentVariables(nodeJSEnvironment); | ||
| process.copyOutputTo(stream); | ||
| process.executeAsync(); | ||
| ExternalProcess.Builder processBuilder = ExternalProcess.builder() |
There was a problem hiding this comment.
please format the line
mykola-mokhnach
approved these changes
Oct 24, 2023
valfirst
force-pushed
the
use-new-selenium-api-for-process-management
branch
from
07c4f2b to
d49acc7
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
org.openqa.selenium.os.CommandLineis deprecated, the replacement isorg.openqa.selenium.os.ExternalProcess.Types of changes
What types of changes are you proposing/introducing to Java client?