fix: Fix Selenium 4.34.0+ compatibility #2298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valfirst
requested review from
mykola-mokhnach,
SrinivasanTarget and
saikrishna321
as code owners
|
|
||
| public class EmptyWebDriver implements WebDriver, ContextAware, | ||
| JavascriptExecutor, HasCapabilities, TakesScreenshot { | ||
| public class EmptyWebDriver implements WebDriver, JavascriptExecutor, HasCapabilities, TakesScreenshot { |
There was a problem hiding this comment.
should it instead implement SupportsContextSwitching ?
There was a problem hiding this comment.
I removed the corresponding methods, they were not used
mykola-mokhnach
approved these changes
Jun 2, 2025
|
@valfirst Selenium 4.34.0 has been released, are you going to release Appium as well? |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
ContextAwareinterface was removed from Selenium: SeleniumHQ/selenium@3c25c92.io.appium.java_client.remote.SupportsContextSwitchingwill be a replacement for the removed interface.Closes #2296.
Types of changes
What types of changes are you proposing/introducing to Java client?
Details
Note: new release will be required once new Selenium release is published.