New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#252 fix #255

Merged
merged 2 commits into from Oct 16, 2015

Conversation

Projects
None yet
4 participants
@TikhomirovSergey
Member

TikhomirovSergey commented Oct 8, 2015

Change list:

  • 252 fix. It affects users that debug their scripts with Eclipse for Mac OS (Linux ?)

    Thanks to @pr4bh4sh for the clue.

  • the additional improvement
    Now processes which find default node.js and Appium node server are destroyed. I really don't guess that they can create zombie-processes, but it is better to be insured :)

@TikhomirovSergey

This comment has been minimized.

Show comment
Hide comment
@TikhomirovSergey

TikhomirovSergey Oct 8, 2015

Member

@Jonahss @pr4bh4sh @saikrishna321
Guys please look at this when you have some free time :)

Member

TikhomirovSergey commented Oct 8, 2015

@Jonahss @pr4bh4sh @saikrishna321
Guys please look at this when you have some free time :)

@Jonahss

This comment has been minimized.

Show comment
Hide comment
@Jonahss

Jonahss Oct 16, 2015

Contributor

Looks good to me :)

Contributor

Jonahss commented Oct 16, 2015

Looks good to me :)

Jonahss added a commit that referenced this pull request Oct 16, 2015

@Jonahss Jonahss merged commit b661581 into appium:master Oct 16, 2015

@Jonahss

This comment has been minimized.

Show comment
Hide comment
@Jonahss

Jonahss Oct 16, 2015

Contributor

Oops, merged before the others had their say.
Uh, if @pr4bh4sh or @saikrishna321 have any comments we can rollback or add a patch. Sorry about that.

Contributor

Jonahss commented Oct 16, 2015

Oops, merged before the others had their say.
Uh, if @pr4bh4sh or @saikrishna321 have any comments we can rollback or add a patch. Sorry about that.

@TikhomirovSergey

This comment has been minimized.

Show comment
Hide comment
@TikhomirovSergey

TikhomirovSergey Oct 16, 2015

Member

It is ok. It is probably they have seen it :)

Member

TikhomirovSergey commented Oct 16, 2015

It is ok. It is probably they have seen it :)

@saikrishna321

This comment has been minimized.

Show comment
Hide comment
@saikrishna321

saikrishna321 Oct 17, 2015

Member

@Jonahss @TikhomirovSergey I did take a look at that .. Looks good to me 👍

Member

saikrishna321 commented Oct 17, 2015

@Jonahss @TikhomirovSergey I did take a look at that .. Looks good to me 👍

@pr4bh4sh

This comment has been minimized.

Show comment
Hide comment
@pr4bh4sh

pr4bh4sh commented Oct 17, 2015

@Jonahss @TikhomirovSergey @saikrishna321 works on my machine too.

@TikhomirovSergey

This comment has been minimized.

Show comment
Hide comment
@TikhomirovSergey

TikhomirovSergey Oct 17, 2015

Member

@Jonahss @Jonahss @saikrishna321
Ok guys. There is one more major enhancement is coming ;). I think this fix will be published with the new feature.

Member

TikhomirovSergey commented Oct 17, 2015

@Jonahss @Jonahss @saikrishna321
Ok guys. There is one more major enhancement is coming ;). I think this fix will be published with the new feature.

@saikrishna321

This comment has been minimized.

Show comment
Hide comment
@saikrishna321

saikrishna321 Oct 17, 2015

Member

@TikhomirovSergey what's the new feature ??

Member

saikrishna321 commented Oct 17, 2015

@TikhomirovSergey what's the new feature ??

@TikhomirovSergey

This comment has been minimized.

Show comment
Hide comment
@TikhomirovSergey
Member

TikhomirovSergey commented Oct 19, 2015

@saikrishna321

This comment has been minimized.

Show comment
Hide comment
@saikrishna321
Member

saikrishna321 commented Oct 21, 2015

👍

@saikrishna321

This comment has been minimized.

Show comment
Hide comment
@saikrishna321

saikrishna321 Oct 21, 2015

Member

@TikhomirovSergey Wordpress app should b a good example to test this feature

(Android)
* Enter username and password and click on Signin Button

(IOS)
* Enter username , password.
* Enter the Site URL and then click on Singin Button

As this feature clearly is useful for identical apps on page object pattern with slight change in the flow.

Your thought ??

Member

saikrishna321 commented Oct 21, 2015

@TikhomirovSergey Wordpress app should b a good example to test this feature

(Android)
* Enter username and password and click on Signin Button

(IOS)
* Enter username , password.
* Enter the Site URL and then click on Singin Button

As this feature clearly is useful for identical apps on page object pattern with slight change in the flow.

Your thought ??

@TikhomirovSergey

This comment has been minimized.

Show comment
Hide comment
@TikhomirovSergey

TikhomirovSergey Oct 21, 2015

Member

@saikrishna321
Yep
Let discuss the feature that is coming out and related ideas here: #228

Member

TikhomirovSergey commented Oct 21, 2015

@saikrishna321
Yep
Let discuss the feature that is coming out and related ideas here: #228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment