New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#272 fix #273

Merged
merged 9 commits into from Dec 10, 2015

Conversation

Projects
None yet
2 participants
@TikhomirovSergey
Member

TikhomirovSergey commented Nov 23, 2015

Change list:

  • the main change is the bug fix of #272. This thing was breaking the starting of a Node.js instances which differ from default (e.g. NSolid)
  • a new usecase was provided

There are problems related to local environment which could break this:

AppiumDriverLocalService service = AppiumDriverLocalService.buildDefaultService();

Also there are situations when should be used an another Node.JS instance, e.g. the instance which is installed in the directory that differs from one defined at the PATH environmental variable.

At this case user is able to set up a value (it should be a full path to desired Node.JS executable) of the NODE_BINARY_PATH environmental variable. Also it is possible to define it programmatically:

//appium.node.js.exec.path
System.setProperty(AppiumServiceBuilder.NODE_PATH , 
"the path to the desired node.js executable");

AppiumDriverLocalService service = AppiumDriverLocalService.buildDefaultService();
  • the refactoring of AppiumServiceBuilder API. It is expected that it is more robust now.
  • scripts which run npm for specific purposes were moved from code to the resources folder. There are no specific actions for users to do. These files will be included in *.jar and used by code of the artefact.
  • pom.xml format issues were improved.
  • tests of compatipility with desktop browsers now work on Chrome

TikhomirovSergey added some commits Nov 23, 2015

#272 fix: initial commit
- #272 fix which should be checked on UNIX-like OS
- test improvements
   - AndroidGestureTest. The improvement of different API levels
   - Tests of compatibility with desktop browsers were migrated to Chrome.
@TikhomirovSergey

This comment has been minimized.

Show comment
Hide comment
@TikhomirovSergey

TikhomirovSergey Nov 23, 2015

Member

One more not a big improvement will be commited soon... Please wait...

Member

TikhomirovSergey commented Nov 23, 2015

One more not a big improvement will be commited soon... Please wait...

TikhomirovSergey added some commits Nov 24, 2015

#272 fix: an additional improvement
The working with npm was moved to scripts which are packed in the jar file. These scripts should be used in runtime.

Changes:
- added scripts
- AppiumServiceBuilder was refactored once again :)
- engines which work with these scrips and npm were implemented
@TikhomirovSergey

This comment has been minimized.

Show comment
Hide comment
@TikhomirovSergey

TikhomirovSergey Nov 26, 2015

Member

@Jonahss @bootstraponline
Please review this PR :)

Member

TikhomirovSergey commented Nov 26, 2015

@Jonahss @bootstraponline
Please review this PR :)

@Jonahss Jonahss merged commit 7cc7e9e into appium:master Dec 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment