New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable nativeWebTap setting for iOS #658

Merged
merged 4 commits into from Jun 17, 2017

Conversation

Projects
None yet
3 participants
@jlipps
Member

jlipps commented Jun 16, 2017

Change list

add a setting for iOS to toggle nativeWebTap

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

Server-side change: appium/appium-xcuitest-driver#455

@SrinivasanTarget

This comment has been minimized.

Show comment
Hide comment
@SrinivasanTarget

SrinivasanTarget Jun 16, 2017

Member

@jlipps Looks good overall. Can you add some tests please? Also our travis is not happy.

Member

SrinivasanTarget commented Jun 16, 2017

@jlipps Looks good overall. Can you add some tests please? Also our travis is not happy.

@jlipps

This comment has been minimized.

Show comment
Hide comment
@jlipps

jlipps Jun 16, 2017

Member

@SrinivasanTarget added tests, and ran it locally with success. note that this will probably fail CI since it is set to iOS 10.2 and requires appium 1.6.6-beta.2 with a fresh download. not sure what the appium local service runs in the java client... but anyway it works!

Member

jlipps commented Jun 16, 2017

@SrinivasanTarget added tests, and ran it locally with success. note that this will probably fail CI since it is set to iOS 10.2 and requires appium 1.6.6-beta.2 with a fresh download. not sure what the appium local service runs in the java client... but anyway it works!

@jlipps

This comment has been minimized.

Show comment
Hide comment
@jlipps

jlipps Jun 16, 2017

Member

found the javadoc error that was failing travis. hopefully it will pass now.

Member

jlipps commented Jun 16, 2017

found the javadoc error that was failing travis. hopefully it will pass now.

@SrinivasanTarget

This comment has been minimized.

Show comment
Hide comment
@SrinivasanTarget

SrinivasanTarget Jun 16, 2017

Member

probably fail CI since it is set to iOS 10.2 and requires appium 1.6.6-beta.2 with a fresh download

We have excluded running tests in CI, so it wouldn't be a problem now. Also this is in pipeline for us.

not sure what the appium local service runs in the java client

Appium local service runs appium as a service automatically at stated port,etc without being started manually.

Member

SrinivasanTarget commented Jun 16, 2017

probably fail CI since it is set to iOS 10.2 and requires appium 1.6.6-beta.2 with a fresh download

We have excluded running tests in CI, so it wouldn't be a problem now. Also this is in pipeline for us.

not sure what the appium local service runs in the java client

Appium local service runs appium as a service automatically at stated port,etc without being started manually.

@codacy-bot

This comment has been minimized.

Show comment
Hide comment
@codacy-bot

codacy-bot Jun 16, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- src/main/java/io/appium/java_client/MobileCommand.java  2
         

Complexity decreasing per file
==============================
+ src/main/java/io/appium/java_client/android/AndroidMobileCommandHelper.java  -2
         

See the complete overview on Codacy

codacy-bot commented Jun 16, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- src/main/java/io/appium/java_client/MobileCommand.java  2
         

Complexity decreasing per file
==============================
+ src/main/java/io/appium/java_client/android/AndroidMobileCommandHelper.java  -2
         

See the complete overview on Codacy

@SrinivasanTarget

LGTM 👍

@jlipps jlipps merged commit 37f5ed3 into master Jun 17, 2017

4 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@jlipps jlipps deleted the jlipps-nwt branch Jun 17, 2017

@jlipps

This comment has been minimized.

Show comment
Hide comment
@jlipps

jlipps Jun 17, 2017

Member

Great! Now how do we publish a beta so someone can use it? :-)

Member

jlipps commented Jun 17, 2017

Great! Now how do we publish a beta so someone can use it? :-)

SrinivasanTarget added a commit to SrinivasanTarget/java-client that referenced this pull request Sep 3, 2017

enable nativeWebTap setting for iOS (#658)
* enable nativeWebTap setting for iOS

* add tests for nativeWebTap method

* make javadoc happy

* conform to style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment