New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.0.0 finalization. Removal of obsolete code. #660

Merged
merged 1 commit into from Jun 23, 2017

Conversation

Projects
None yet
4 participants
@TikhomirovSergey
Member

TikhomirovSergey commented Jun 17, 2017

Change list

  • Removal of obsolete code.

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

I think it is time complete the 5.0.0. There is a lot of BETA builds which will help users to migrate their projects to the new stable version.

@TikhomirovSergey

This comment has been minimized.

Show comment
Hide comment
@TikhomirovSergey

TikhomirovSergey Jun 17, 2017

Member

@SrinivasanTarget could you run iOS tests and check the result?

Member

TikhomirovSergey commented Jun 17, 2017

@SrinivasanTarget could you run iOS tests and check the result?

@codacy-bot

This comment has been minimized.

Show comment
Hide comment
@codacy-bot

codacy-bot Jun 18, 2017

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 1
           

Complexity decreasing per file
==============================
+ src/main/java/io/appium/java_client/ios/IOSMobileCommandHelper.java  -3
+ src/main/java/io/appium/java_client/android/AndroidMobileCommandHelper.java  -5
+ src/main/java/io/appium/java_client/TouchAction.java  -4
+ src/main/java/io/appium/java_client/ios/IOSDriver.java  -1
+ src/main/java/io/appium/java_client/AppiumDriver.java  -13
+ src/main/java/io/appium/java_client/android/AndroidDriver.java  -1
+ src/main/java/io/appium/java_client/MobileCommand.java  -1
+ src/main/java/io/appium/java_client/MobileElement.java  -5
         

See the complete overview on Codacy

codacy-bot commented Jun 18, 2017

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 1
           

Complexity decreasing per file
==============================
+ src/main/java/io/appium/java_client/ios/IOSMobileCommandHelper.java  -3
+ src/main/java/io/appium/java_client/android/AndroidMobileCommandHelper.java  -5
+ src/main/java/io/appium/java_client/TouchAction.java  -4
+ src/main/java/io/appium/java_client/ios/IOSDriver.java  -1
+ src/main/java/io/appium/java_client/AppiumDriver.java  -13
+ src/main/java/io/appium/java_client/android/AndroidDriver.java  -1
+ src/main/java/io/appium/java_client/MobileCommand.java  -1
+ src/main/java/io/appium/java_client/MobileElement.java  -5
         

See the complete overview on Codacy

import io.appium.java_client.CommandExecutionHelper;
import io.appium.java_client.ExecutesMethod;
import java.time.Duration;

This comment has been minimized.

@SrinivasanTarget

This comment has been minimized.

Show comment
Hide comment
@SrinivasanTarget

SrinivasanTarget Jun 18, 2017

Member

could you run iOS tests and check the result?

Sure will review in sometime

Member

SrinivasanTarget commented Jun 18, 2017

could you run iOS tests and check the result?

Sure will review in sometime

@TikhomirovSergey TikhomirovSergey merged commit a41dca1 into appium:master Jun 23, 2017

3 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment