New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear existing actions/parameters after perform is invoked #663

Merged
merged 1 commit into from Jun 30, 2017

Conversation

Projects
None yet
4 participants
@mykola-mokhnach
Contributor

mykola-mokhnach commented Jun 26, 2017

Change list

Clear existing actions/parameters after perform method of the corresponding actions chain is invoked

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

I find the current behaviour confusing, since it may cause issues like this one: appium/appium#8734

The second possible solution might be to make a chain immutable after perform is called, so it will reject all the further parameter/action adding operations after perform method has been invoked once on a chain instance.

@codacy-bot

This comment has been minimized.

Show comment
Hide comment
@codacy-bot

codacy-bot Jun 26, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- src/main/java/io/appium/java_client/MultiTouchAction.java  1
         

See the complete overview on Codacy

codacy-bot commented Jun 26, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- src/main/java/io/appium/java_client/MultiTouchAction.java  1
         

See the complete overview on Codacy

@TikhomirovSergey

This comment has been minimized.

Show comment
Hide comment
@TikhomirovSergey

TikhomirovSergey Jun 27, 2017

Member

@mykola-mokhnach Hi! I will review it ASAP. Thank you :)

Member

TikhomirovSergey commented Jun 27, 2017

@mykola-mokhnach Hi! I will review it ASAP. Thank you :)

@TikhomirovSergey TikhomirovSergey merged commit 08fe157 into appium:master Jun 30, 2017

3 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@mykola-mokhnach mykola-mokhnach deleted the mykola-mokhnach:clear_touch branch Aug 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment