New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update touch ID enroll method #695

Merged
merged 1 commit into from Aug 25, 2017

Conversation

Projects
None yet
3 participants
@mykola-mokhnach
Contributor

mykola-mokhnach commented Aug 17, 2017

Change list

Now it is possible to set the desired state for Touch ID Enrolment feature.

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

the PR is based on appium/appium-xcuitest-driver#506

*/
@Deprecated
default void toggleTouchIDEnrollment() {

This comment has been minimized.

@SrinivasanTarget

SrinivasanTarget Aug 17, 2017

Member

@mykola-mokhnach We haven't released a version after this implementation. Can we remove this or Do you still wanted it to be marked deprecated?

@SrinivasanTarget

SrinivasanTarget Aug 17, 2017

Member

@mykola-mokhnach We haven't released a version after this implementation. Can we remove this or Do you still wanted it to be marked deprecated?

This comment has been minimized.

@mykola-mokhnach

mykola-mokhnach Aug 17, 2017

Contributor

marking it as deprecated is safer. We can remove as soon as beta is released (what we, actually, always do)

@mykola-mokhnach

mykola-mokhnach Aug 17, 2017

Contributor

marking it as deprecated is safer. We can remove as soon as beta is released (what we, actually, always do)

This comment has been minimized.

@SrinivasanTarget
@SrinivasanTarget
@TikhomirovSergey

@mykola-mokhnach It looks fine. I want to run the test, merge this PR if everything is ok and publish it in 5.0.0 on this (26.08.2017-27.08.2017) weekend.

@TikhomirovSergey TikhomirovSergey merged commit 7af738f into appium:master Aug 25, 2017

3 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@mykola-mokhnach mykola-mokhnach deleted the mykola-mokhnach:update_enroll branch Sep 7, 2017

@mykola-mokhnach

This comment has been minimized.

Show comment
Hide comment
@mykola-mokhnach
Contributor

mykola-mokhnach commented Sep 17, 2017

@KazuCocoa FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment