Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map sending keys to active element for W3C compatibility #966

Merged
merged 2 commits into from
Jul 4, 2018

Conversation

mykola-mokhnach
Copy link
Contributor

Change list

Map sendKeysToActiveElement to W3C actions. Previously calling keyboard.sendKeys would throw an exception, since W3C standard does not declare sendKeysToActiveElement endpoint.

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Copy link
Member

@SrinivasanTarget SrinivasanTarget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does UIA2 or XCUI or Espresso Driver has this endpoint?

@mykola-mokhnach
Copy link
Contributor Author

UIA2 and Espresso do have it.

XCUITest driver does not, since XCTest itself does not support generation of arbitrary key events (yet).

@mykola-mokhnach mykola-mokhnach merged commit 541eca8 into appium:master Jul 4, 2018
@mykola-mokhnach mykola-mokhnach deleted the send_keys_active branch August 7, 2018 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants