add a duration for scroll for ios #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appium/webdriver/webdriver.py
Outdated
| @@ -425,18 +425,19 @@ def create_web_element(self, element_id): | |||
| return MobileWebElement(self, element_id) | |||
|
|
|||
| # convenience method added to Appium (NOT Selenium 3) | |||
| def scroll(self, origin_el, destination_el): | |||
| def scroll(self, origin_el, destination_el, duration = 250): | |||
There was a problem hiding this comment.
the default duration should be at least 600 ms
There was a problem hiding this comment.
any particular reason for default duration to be at least 600 ms, I am guessing you recommend this duration for a smooth scroll.
VenkateshPS
approved these changes
Oct 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not working scroll from one element to another as expected in Appium 1.9.1 using python client with the robotframework-appiumlibrary on the iOS 12 #254