feat: add pause in drag_and_drop #961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -61,19 +61,24 @@ def scroll(self, origin_el: WebElement, destination_el: WebElement, duration: Op | |||
| actions.perform() | |||
| return cast('WebDriver', self) | |||
|
|
|||
| def drag_and_drop(self, origin_el: WebElement, destination_el: WebElement) -> 'WebDriver': | |||
| def drag_and_drop( | |||
| self, origin_el: WebElement, destination_el: WebElement, pause: Union[float, None] = None | |||
There was a problem hiding this comment.
I prefer Optional[float]
|
|
||
| Returns: | ||
| Union['WebDriver', 'ActionHelpers']: Self instance | ||
| """ | ||
| actions = ActionChains(self) | ||
| # 'mouse' pointer action | ||
| actions.w3c_actions.pointer_action.click_and_hold(origin_el) | ||
| if pause: |
There was a problem hiding this comment.
if pause is not None and pause > 0
|
|
||
| Returns: | ||
| Union['WebDriver', 'ActionHelpers']: Self instance | ||
| """ | ||
| actions = ActionChains(self) | ||
| # 'mouse' pointer action | ||
| actions.w3c_actions.pointer_action.click_and_hold(origin_el) | ||
| if pause: | ||
| actions.w3c_actions.pointer_action.pause(pause) |
There was a problem hiding this comment.
I assume we need to convert the value to integer milliseconds according to w3c spec
There was a problem hiding this comment.
selenium client takes care it
https://github.com/SeleniumHQ/selenium/blob/93c780439f2886607474a6cebaf4e678f9730047/py/selenium/webdriver/common/actions/pointer_actions.py#L198-L200
https://github.com/SeleniumHQ/selenium/blob/93c780439f2886607474a6cebaf4e678f9730047/py/selenium/webdriver/common/actions/pointer_input.py#L63-L64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #955