Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move JS helpers to separate file #2

Closed
yury opened this issue Feb 20, 2012 · 1 comment
Closed

Move JS helpers to separate file #2

yury opened this issue Feb 20, 2012 · 1 comment

Comments

@yury
Copy link
Collaborator

yury commented Feb 20, 2012

Maybe it is better to move _access, safe and other from template.rb to separate file and not pollute small templates?

It can be as an option for skim engine.
User can simply all helpers via require 'skim' in his application.js
@jfirebaugh
Copy link
Collaborator

Agreed, I will definitely accept a good pull request for this.

yury added a commit to yury/skim that referenced this issue Feb 22, 2012
@yury
Closes appjudo#2; Moved skim js helpers to separate file
be58843 
- Moved JS helpers to vendor/assets/javascripts/skim.js.coffee
- Introduced :use_asset Skim::Engine option (default to false)
yury added a commit to yury/skim that referenced this issue Feb 23, 2012
@yury @jfirebaugh
Closes appjudo#2; Moved skim js helpers to separate file
bc54f8d 
- Moved JS helpers to vendor/assets/javascripts/skim.js.coffee
- Introduced :use_asset Skim::Engine option (default to false)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yury @jfirebaugh