Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can slim-1.3* be supported? #23

Closed
vollnhals opened this issue Nov 7, 2012 · 10 comments
Closed

Can slim-1.3* be supported? #23

vollnhals opened this issue Nov 7, 2012 · 10 comments

Comments

@vollnhals
Copy link

Hi!

Why is skim currently depending on slim <= 1.2.2?
Can we support version 1.3?

@grossws
Copy link
Contributor

grossws commented Dec 19, 2012

You can use gem 'skim', :git => "https://github.com/Termina1/skim.git" in your Gemfile,
it should work with slim <= 1.3.*

@grossws
Copy link
Contributor

grossws commented Dec 19, 2012

Sorry, it wouldn't work because of slim API change.

@grossws
Copy link
Contributor

grossws commented Dec 19, 2012

I've added support for slim 1.3.x at https://github.com/grossws/skim.

@ryanwood
Copy link

@jfirebaugh @grossws Would it be possible to get a pull request done so this can be merged into this repo. Slim is coming up on v2.0.0 and Skim is falling significantly behind (having a fixed dependency at 1.2.2). I really love Skim and would like to see it keep up with Slim, at least to be compatible with 1.x. Thanks for the work on this.

Thoughts?

@grossws
Copy link
Contributor

grossws commented Feb 14, 2013

@ryanwood, I'll take a look at current slim version (1.3.7 as I know) and than may answer to you.
My previos try to migrate skim to slim 1.3.* wasn't successful: tests were failing.

@wulftone
Copy link

wulftone commented Jun 3, 2013

Does anyone have this working for slim 1.3.x?.. or 2.0.0, for that matter?

@grossws
Copy link
Contributor

grossws commented Jun 3, 2013

I don't have enough time to do it now. As soon as I will have it for skim, I'll try to migrate skim to slim v2.x

@jfirebaugh
Copy link
Collaborator

2.0 is now supported thanks to @yury.

@wulftone
Copy link

Awesome! Thank you @yury!

@yury
Copy link
Collaborator

yury commented Jun 28, 2013

welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants