-
Notifications
You must be signed in to change notification settings - Fork 347
extend ToolInfoV0 with command visibility #669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/// Extended description of the command's functionality. | ||
public var discussion: String? | ||
/// Command should appear in help displays. | ||
public var shouldDisplay: Bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add = true
as a fall back for older json generated before this option was introduced?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated now - apologies for the delay, didn't have my laptop with me for the past week. Updated and rebased to resolve conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small change needed, otherwise looks good
- resolves apple#668 by extending the ToolInfoV0 (help dump) struct to include visibility information for commands (already exists for arguments). - updates test output to verify existing examples extend with the additional key.
4e8636c
to
6652f22
Compare
@swift-ci test |
Thanks @rauhul - I missed one piece in the rebasing I think, just made a further commit to line that up properly, so next round should sail through CI without issue.. I hope. Locally verified, anyway. |
@swift-ci Please test |
Sorry for the last minute nit pick, can we add a test case that results in We can update |
@rauhul Sure, can definitely do that. |
I've updated the existing test - command |
ship it! |
@swift-ci test |
Checklist