Add singleton to indicate which shell version is requesting completion candidates #690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n candidates Create a `String?` singleton named `CompletionShell.requestingVersion` that indicates which shell version is requesting completion candidates. It will be set to the correct value while a Swift custom completion function is executing to offer completions for a word from a command line (e.g., while `customCompletion` from `@Option(completion: .custom(customCompletion))` executes). Otherwise, it will be set to `nil`. The requesting shell version is communicated to the Swift app via an environment variable named `SAP_SHELL_VERSION`, which is exported by each of the generated completion scripts. Improve some nearby DocC. Resolve apple#689 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add singleton to indicate which shell version is requesting completion candidates.
Create a
String?singleton namedCompletionShell.requestingVersionthat indicates which shell version is requesting completion candidates.It will be set to the correct value while a Swift custom completion function is executing to offer completions for a word from a command line (e.g., while
customCompletionfrom@Option(completion: .custom(customCompletion))executes). Otherwise, it will be set tonil.The requesting shell version is communicated to the Swift app via an environment variable named
SAP_SHELL_VERSION, which is exported by each of the generated completion scripts.Improve some nearby DocC.
Resolve #689
Replace this paragraph with a description of your changes and rationale. Provide links to an existing issue or external references/discussions, if appropriate.
Checklist