Skip to content

Conversation

rauhul
Copy link
Contributor

@rauhul rauhul commented Feb 5, 2025

Upstreams swiftly's generate-docs-plugin with minimal changes. Adds
tests against argument-parser's built in example tools.

The initial version of this tool is extremely minimal and should be
extended to output much more information contained in tool info, like
generate-manual does.

@rauhul
Copy link
Contributor Author

rauhul commented Feb 5, 2025

@swift-ci test

@rauhul rauhul added the enhancement New feature or request label Feb 5, 2025
@rauhul
Copy link
Contributor Author

rauhul commented Feb 5, 2025

@swift-ci test

return ""
}

// TODO: default values, short, etc.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: It'll be interesting to see how these should be handled in the general case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely, I've pinged the documentation workgroup on slack to see if they general ideas.

return ""
}

// TODO: default values, values, short, etc.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: and same here

Upstreams swiftly's generate-docs-plugin with minimal changes. Adds
tests against argument-parser's built in example tools.

The initial version of this tool is extremely minimal and should be
extended to output much more information contained in tool info, like
generate-manual does.
@rauhul rauhul force-pushed the generate-docc-reference branch from f9e9050 to 7f294c0 Compare February 5, 2025 17:10
@@ -37,7 +37,6 @@ extension GenerateManualError: CustomStringConvertible {

@main
struct GenerateManual: ParsableCommand {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Maybe this change doesn't need to be here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah but it annoyed me and I didn't feel like an independent PR to fix just that line 🙈

I want this stuff to handled by a formatting workflow but I need the infra owners to turn on GitHub actions. Which I keep asking for.

Copy link
Member

@natecook1000 natecook1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tiniest possible nit, otherwise LGTM 👍🏻

rauhul and others added 2 commits February 5, 2025 09:40
@rauhul rauhul enabled auto-merge (squash) February 5, 2025 17:42
@rauhul
Copy link
Contributor Author

rauhul commented Feb 5, 2025

@swift-ci test

@rauhul rauhul merged commit 9289e31 into main Feb 5, 2025
2 checks passed
@rauhul rauhul deleted the generate-docc-reference branch February 5, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants