-
Notifications
You must be signed in to change notification settings - Fork 343
Add generate-docc-reference plugin #694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci test |
@swift-ci test |
return "" | ||
} | ||
|
||
// TODO: default values, short, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: It'll be interesting to see how these should be handled in the general case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely, I've pinged the documentation workgroup on slack to see if they general ideas.
return "" | ||
} | ||
|
||
// TODO: default values, values, short, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: and same here
Upstreams swiftly's generate-docs-plugin with minimal changes. Adds tests against argument-parser's built in example tools. The initial version of this tool is extremely minimal and should be extended to output much more information contained in tool info, like generate-manual does.
f9e9050
to
7f294c0
Compare
@@ -37,7 +37,6 @@ extension GenerateManualError: CustomStringConvertible { | |||
|
|||
@main | |||
struct GenerateManual: ParsableCommand { | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Maybe this change doesn't need to be here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah but it annoyed me and I didn't feel like an independent PR to fix just that line 🙈
I want this stuff to handled by a formatting workflow but I need the infra owners to turn on GitHub actions. Which I keep asking for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tiniest possible nit, otherwise LGTM 👍🏻
Co-authored-by: Nate Cook <natecook@apple.com>
@swift-ci test |
Upstreams swiftly's generate-docs-plugin with minimal changes. Adds
tests against argument-parser's built in example tools.
The initial version of this tool is extremely minimal and should be
extended to output much more information contained in tool info, like
generate-manual does.