Skip to content

Add docc support and publish documentation to GitHub pages #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 11, 2022

Conversation

Kyle-Ye
Copy link
Contributor

@Kyle-Ye Kyle-Ye commented Apr 3, 2022

  • Move Guides into swift-docc based format
  • Publish documentation to Github pages

swiftlang/swift-docc#109

Copy link
Member

@phausler phausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parkera and I discussed earlier about how this does mean that we are publishing docs before stuff is completely settled per reviews - as long as we generate stuff at given sub-major milestones before 1.0 I think that should be fine as per documentation.


# Use git worktree to checkout the gh-pages branch of this repository in a gh-pages sub-directory
git fetch
git worktree add --checkout gh-pages origin/gh-pages
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to lands this we will need to make a blank branch gh-pages as well as do the remaining setup for that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we need a gh-pages branch and add the environment GitHub action.

@Kyle-Ye Kyle-Ye requested a review from phausler April 5, 2022 09:17
@Kyle-Ye
Copy link
Contributor Author

Kyle-Ye commented Apr 11, 2022

Fixed the CR suggestion and rebased main to solve the conflicts.
Could you please review this again? @phausler

Copy link
Member

@phausler phausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So ive been coordinating with some other folks to get the remainder of the back-end tasks finished for this. There are some additional tasks we will need before it will all be ready to publish;

  1. we need a redirect similar to how swift-argument-parser did it (however perhaps it might be good to stash that redirect.html in say a lib/ directory.
  2. some of the sub-titles are kinda wonky for the guides being imported as articles some minor restructuring will be needed for those.
  3. I think there are some general enhancements we can do for the documentation to show methods as extensions to AsyncSequence (I have some ideas here we can explore)

none of those are to say blockers for getting this first step done; we can split it up into a couple of issues so we can get it done together.

@phausler
Copy link
Member

here is what it looks like currently: https://phausler.github.io/swift-async-algorithms/documentation/asyncalgorithms/

@phausler phausler merged commit a3576e6 into apple:main Apr 11, 2022
@Kyle-Ye Kyle-Ye deleted the docc-support branch April 12, 2022 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants