ContainerRegistry: Remove return-type overloaded client functions #145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Return type overloads can be puzzling for new readers because the same function call returns a different type depending on where it is called. In some cases a type annotation is needed at the call site, but when the overloaded function is the final call in another function the compiler can infer the type, so the reader needs to know to check the type of the enclosing function.
In addition, in a future pull request we will need access to the underlying data returned by the HTTP client, in order to verify digests and create
ContentDescriptor
objects. This refactoring starts to prepare for that and makes the code easier to understand.Modifications
executeRequestThrowing()
getBlob()
Result
Refactoring. No functional change.
Test Plan
Existing tests continue to pass.