ContainerRegistry: Provide ContentDescriptors for manifests #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returning a ContentDescriptor provides the information needed to add the manifest to an image index, making it possible to build multi-architecture images.
euanh
added
kind/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In a multi-arch image, several architecture-specific manifests are grouped together under the same index. The index has a list of content descriptors pointing to the manifests.
Currently,
containertoolcreates single-architecture images for which the root object is a manifest. Returning a content descriptor for the manifest allows it to create an index which points to the manifest.On its own this does not allow
containertoolto create multi-arch images, but it opens that possibility for the future. It is a necessary towards being able to write container images to disk.Modifications
Result
containertoolcan retrieve aContentDescriptorfor a manifest it has written or fetched.Test Plan
Existing tests have been updated to match the new signatures and continue to pass.