Set the default arguments passed to the entrypoint #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
! needs to be last option passed to tool, as it might cmd values might be options themselves
euanh
approved these changes
Sep 16, 2025
|
Thanks @ebariaux, this is a great improvement. |
euanh
added
kind/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Allow configuring the CMD entry of the generated image config.
Modifications
Added the argument parsing in containertool.swift and pass it to the publish method.
Given the CMD entries are often options themselves, the .remaining parsing strategy is used.
This means this option must be the last.
Also means that in ContainerImageBuilder/main.swift, the order has been altered when building the arguments used to call the containertool process.
Result
Can configure CMD entry, e.g. for a Vapor example
swift package --swift-sdk aarch64-swift-linux-musl build-container-image --repository localhost:5000/hello --cmd "serve" "--env" "production" "--hostname" "0.0.0.0" "--port" "8080"
Fixes: #89
Test Plan
Added a test-containertool-cmd.sh script to perform some basic testing.