Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use percentEncode(path, component: .path) instead of percentEncodePath(path) #632

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Use percentEncode(path, component: .path) instead of percentEncodePath(path) #632

merged 1 commit into from
Jun 4, 2024

Conversation

nnabeyang
Copy link
Contributor

@nnabeyang nnabeyang commented May 23, 2024 •
edited
Loading

In RFC3986Parser, while constructing the percent-encoded urlString, .user, .password, .host, .query, and .fragment all call percentEncode(_:component:), but only .path calls percentEncodePath(_:).
This PR replaces percentEncodePath(_:) with percentEncode(_:component:) for consistency.

@jmschonfeld jmschonfeld requested a review from jrflat May 23, 2024 21:28
@jmschonfeld
Copy link
Contributor

@swift-ci please test

jrflat
jrflat approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@jrflat jrflat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@jrflat jrflat merged commit 0101305 into swiftlang:main Jun 4, 2024
2 checks passed
@nnabeyang nnabeyang deleted the replace_method_rfc3986_parser branch June 5, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrflat jrflat jrflat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nnabeyang @jmschonfeld @jrflat