Make HPACKHeaders hashable. #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: HPACKHeaders is equatable, and it rarely makes sense to have a type that is equatable but not hashable. The definition of equatability is pretty limited here (see apple#342) but we can define a definition of hashability consistent with it. Modifications: - Make HPACKHeaders hashable. Result: People can store HPACKHeaders in Sets
Lukasa
requested review from
FranzBusch,
glbrntt,
dnadoba,
fabianfett and
Davidde94
Davidde94
approved these changes
May 4, 2022
Sources/NIOHPACK/HPACKHeader.swift
Outdated
| @@ -394,6 +394,9 @@ extension HPACKHeaders: CustomStringConvertible { | |||
| } | |||
| } | |||
|
|
|||
| // NOTE: This is a bad definition of equatable and hashable. In particular, both order and | |||
| // indexability are ignored. We're sort of stuck with this behaviour now and cannot change it, | |||
| // but in the next major version we should strongly consider revising it. | |||
There was a problem hiding this comment.
Should we link a GH issue?
There was a problem hiding this comment.
Oh, I think this comment is just unnecessarily aggressive.
dnadoba
reviewed
May 4, 2022
Co-authored-by: David Nadoba <dnadoba@gmail.com>
dnadoba
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
HPACKHeaders is equatable, and it rarely makes sense to have a type that
is equatable but not hashable. The definition of equatability is pretty
limited here (see #342) but we can define a definition of hashability
consistent with it.
Modifications:
Result:
People can store HPACKHeaders in Sets