Forbid creating new channels after TCP shutdown. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: If users attempt to create new stream channels after TCP shutdown, or if they race with it, they may find that their promises hang forever. That's an unforgiveable sin in NIO programs: promises must never hang forever. Modifications: - Add a state tracking flag to work out if we can still create channels. - Test that we correctly forbid them after TCP shutdown is received. Result: No hanging promises.
artemredkin
approved these changes
Aug 14, 2020
artemredkin
pushed a commit
to artemredkin/swift-nio-ssh
that referenced
this pull request
Feb 19, 2021
Motivation: If users attempt to create new stream channels after TCP shutdown, or if they race with it, they may find that their promises hang forever. That's an unforgiveable sin in NIO programs: promises must never hang forever. Modifications: - Add a state tracking flag to work out if we can still create channels. - Test that we correctly forbid them after TCP shutdown is received. Result: No hanging promises.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
If users attempt to create new stream channels after TCP shutdown, or if
they race with it, they may find that their promises hang forever.
That's an unforgiveable sin in NIO programs: promises must never hang
forever.
Modifications:
Result:
No hanging promises.
Fixes #36.