More changes to support building with Musl. #2628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use direct syscall for `renameat2` because Musl doesn't include a wrapper for it. Similarly, define the constants ourselves. Add Musl imports in relevant places.
Lukasa
approved these changes
Jan 18, 2024
Austinpayne
added a commit
to Austinpayne/swift-nio
that referenced
this pull request
Feb 9, 2024
When using `-Xcc -Werror` flags redefining macros results in a compilation. Instead we check if they are not defined before defining for the musl case. Fixes regression in apple#2628.
Austinpayne
added a commit
to Austinpayne/swift-nio
that referenced
this pull request
Feb 9, 2024
When using `-Xcc -Werror` flags redefining macros results in a compilation error. Instead we check if they are not defined before defining for the musl case. Fixes regression in apple#2628.
glbrntt
added a commit
that referenced
this pull request
Feb 9, 2024
When using `-Xcc -Werror` flags redefining macros results in a compilation error. Instead we check if they are not defined before defining for the musl case. Fixes regression in #2628. Co-authored-by: Austin Payne <austin@passivelogic.com> Co-authored-by: George Barnett <gbarnett@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support using NIO with Musl on Linux.
Motivation:
I'm trying to make Swift NIO work on top of Musl so that we can build fully statically linked binaries for Linux.
Modifications:
Use direct syscall for
renameat2because Musl doesn't include a wrapper for it. Similarly, define the constants ourselves.Add Musl imports in relevant places.
Result:
Building NIO on Musl will work again :-)